Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vocab.to_disk exclude doesn't respect vectors #11833 #11834

Merged
merged 1 commit into from Nov 21, 2022
Merged

Vocab.to_disk exclude doesn't respect vectors #11833 #11834

merged 1 commit into from Nov 21, 2022

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Nov 19, 2022 •
edited

closes #11833

Description

Types of change

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@MarcoGorelli
Copy link
Contributor Author

Found this while testing out https://github.com/MarcoGorelli/cython-lint :

spacy/vocab.pyx:471:22: Comparison between constants
spacy/vocab.pyx:473:22: Comparison between constants

@adrianeboyd adrianeboyd changed the title Vector.to_disk exclude doesn't respect vectors #11833 Vocab.to_disk exclude doesn't respect vectors #11833 Nov 21, 2022
@adrianeboyd
Copy link
Contributor

Thanks for the PR! (A tool for cython linting sounds nice!)

@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation feat / vectors Feature: Word vectors and similarity labels Nov 21, 2022
@adrianeboyd adrianeboyd merged commit f0d8309 into explosion:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / vectors Feature: Word vectors and similarity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vector.to_disk exclude doesn't respect vectors
2 participants
@MarcoGorelli @adrianeboyd