Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow spacy-transformers v1.2.x in transformers extra #12092

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Allow spacy-transformers v1.2.x in transformers extra #12092

merged 1 commit into from
Jan 11, 2023

Conversation

adrianeboyd
Copy link
Contributor

Description

Allow spacy-transformers v1.2.x in transformers extra.

Types of change

Enhancement?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added meta Meta topics, e.g. repo organisation and issue management feat / transformer Feature: Transformer labels Jan 11, 2023
@adrianeboyd
Copy link
Contributor Author

To clarify the version range: a model package should specify either v1.1.x or v1.2.x due to differences in behavior (model serialization, slow/fast tokenizer alignments), but spacy v3.5.0 itself is compatible with either.

@svlandeg svlandeg merged commit e0168cc into explosion:master Jan 11, 2023
@ringohoffman ringohoffman mentioned this pull request Sep 27, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat / transformer Feature: Transformer meta Meta topics, e.g. repo organisation and issue management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrianeboyd @svlandeg