Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spacy-transformers v1.3.x in transformers extra #13025

Merged

Conversation

ringohoffman
Copy link
Contributor

@ringohoffman ringohoffman commented Sep 27, 2023

Description

Allow spacy-transformers v1.3.x in transformers extra. This adds support for transformers==4.33.*.

Related: #12092

Types of change

Enhancement

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@ringohoffman
Copy link
Contributor Author

@svlandeg @adrianeboyd

@adrianeboyd
Copy link
Contributor

Yes, we're definitely planning to do this, but first for v3.7 due to the potential incompatibilities in the saved torch models (see the first attempt in #12877, which was reverted after spacy-transformers v1.3.0 was yanked).

Let me modify the base branch and let the tests run (although the extras aren't checked in any way by the tests).

@adrianeboyd adrianeboyd added v3.7 Related to v3.7 feat / transformer Feature: Transformer labels Sep 28, 2023
@adrianeboyd adrianeboyd changed the base branch from master to develop September 28, 2023 14:05
@adrianeboyd adrianeboyd merged commit 483d4a5 into explosion:develop Sep 29, 2023
8 checks passed
@ringohoffman ringohoffman deleted the bump-spacy-transformers-1-3-x branch September 29, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat / transformer Feature: Transformer v3.7 Related to v3.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants