Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PhraseMatcher to work with new Matcher #614

Merged
merged 2 commits into from
Nov 8, 2016

Conversation

sadovnychyi
Copy link
Contributor

Motivation and Context

#613

How Has This Been Tested?

PhraseMatcher wasn't tested at all, I've added a basic test for it.

Types of changes

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality to spaCy)
  • Breaking change (fix or feature causing change to spaCy's existing functionality)
  • Documentation (Addition to documentation of spaCy)

Checklist:

  • My code follows spaCy's code style. (it's coming soon though)
  • My change requires a change to spaCy's documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

P.S. Would be cool to have test script using makefile or something to easily run them. I had to look into travis scripts to learn how to do it.

@honnibal
Copy link
Member

honnibal commented Nov 8, 2016

Thanks! Looks good.

@honnibal honnibal merged commit e0f5a60 into explosion:master Nov 8, 2016
@buingoctruong
Copy link

buingoctruong commented Mar 1, 2019

Hi all!

My computer is installing:

Window 7
Python 3.5.4
Spacy 2.0.18

I got this error < No name 'Matcher' in module 'spacy.matcher' > when trying to use the following snippet

import spacy, code
from spacy.matcher import Matcher

Please anyone Can help me? thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants