Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error if deps not provided with heads #8335

Merged
merged 10 commits into from Jun 15, 2021
Merged

Raise error if deps not provided with heads #8335

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d110714
Fill in deps if not provided with heads
polm Jun 10, 2021
56c9b13
Use "dep" instead of a blank string
polm Jun 10, 2021
9c4d390
Throw error on heads without deps
polm Jun 12, 2021
6d535ea
Add a test
polm Jun 12, 2021
1840e51
Fix tests
polm Jun 12, 2021
b6ca4ac
Formatting
polm Jun 12, 2021
1460a8f
Fix all tests
polm Jun 12, 2021
523f22f
Fix a test I missed
polm Jun 13, 2021
704fff2
Revise error message
polm Jun 15, 2021
da7d8d8
Clean up whitespace
adrianeboyd Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions spacy/tokens/doc.pyx
View file
Open in desktop
Expand Up @@ -275,6 +275,8 @@ cdef class Doc:
deps = [dep if dep is not None else MISSING_DEP_ for dep in deps]
if deps and not heads:
heads = [0] * len(deps)
if heads and not deps:
deps = ['dep'] * len(heads)
svlandeg marked this conversation as resolved.
Show resolved Hide resolved
if sent_starts is not None:
for i in range(len(sent_starts)):
if sent_starts[i] is True:
Expand Down