Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for langchain model ID issue #374

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Nov 17, 2023

Description

Add workaround for langchain model ID issue: langchain doesn't use a standardized arg name for models (anymore?). This clumsy workaround tries a number of known arg names. Follow-up solutions might be smarter by reading out the validation errors and fixing the model, but at this point it's not clear whether this would even be a more robust solution.

Fixes #373 and #372.

Corresponding documentation PR

-

Types of change

Bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added bug Something isn't working feat/model Feature: models third party Third-party software (integrations etc.) labels Nov 17, 2023
@rmitsch rmitsch merged commit 6f2b241 into main Nov 17, 2023
11 checks passed
@rmitsch rmitsch deleted the fix/langchain-model-init branch November 17, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat/model Feature: models third party Third-party software (integrations etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported Langchain models
1 participant