Improve exception when CuPy/PyTorch MPS is not installed #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than raising a generic `No GPU devices can be detected` when CuPy or PyTorch with MPS isn't installed, but raise more specific errors.
👷 Deploy request for thinc-ai pending review.Visit the deploys page to approve it
|
shadeMe
reviewed
Mar 14, 2023
It's undocumented.
shadeMe
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
require_gpudoes not distinguish between different failure scenarios, which makes it harder to debug why GPU support is not working. See e.g.explosion/spaCy#12410
Rather than raising a generic
No GPU devices can be detectedwhen CuPy or PyTorch with MPS isn't installed, this change adds more specific errors.Types of change
Enhancement
Checklist