Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cupy.cublas import #921

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Fix cupy.cublas import #921

merged 3 commits into from
Feb 7, 2024

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Feb 7, 2024

Description

Reported in #920. Also update MyPy dependency to fix checking of Torch types.

Types of change

Bugfix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@danieldk danieldk added bug Bugs and behaviour differing from documentation feat / ops Backends and maths labels Feb 7, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 7, 2024 •
edited

👷 Deploy request for thinc-ai pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4fef3ca

svlandeg
svlandeg approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@svlandeg svlandeg merged commit 307a4f8 into explosion:master Feb 7, 2024
10 checks passed
@svlandeg svlandeg mentioned this pull request Feb 7, 2024
Closed
@svlandeg svlandeg linked an issue Feb 7, 2024 that may be closed by this pull request
Spacy fails with "module 'cupy' has no attribute 'cublas'" #920
Closed
@danieldk danieldk deleted the bugfix/cupy-import branch February 7, 2024 18:34
@Keating950 Keating950 mentioned this pull request Mar 20, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / ops Backends and maths
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spacy fails with "module 'cupy' has no attribute 'cublas'"
2 participants
@danieldk @svlandeg