Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCTV module #251

Merged
merged 21 commits into from Dec 21, 2023
Merged

CCTV module #251

merged 21 commits into from Dec 21, 2023

Conversation

PHIDIAS0303
Copy link
Contributor

No description provided.

Cooldude2606
Cooldude2606 requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Cooldude2606 Cooldude2606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is not runtime safe so must be changed.

modules/gui/surveillance.lua Outdated Show resolved Hide resolved
modules/gui/surveillance.lua Outdated Show resolved Hide resolved
modules/gui/surveillance.lua Outdated Show resolved Hide resolved
@PHIDIAS0303
Copy link
Contributor Author

i have no idea what i am doing

Cooldude2606
Cooldude2606 reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@Cooldude2606 Cooldude2606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes need, mostly around the size of buttons.
Could you make the cameras disabled by default, it feels odd to have both enabled on your player by default.
Once that is complete it can be merged.

modules/gui/surveillance.lua Outdated Show resolved Hide resolved
modules/gui/surveillance.lua Outdated Show resolved Hide resolved
@Cooldude2606
Copy link
Member

When a player leaves the game they are removed from the selection list. This results in the selected index returning 0 for "none selected". You need to include a check for this in on_tick to prevent error spam in the logs.
Given player value (0) is too small, the data type allows values from 1 to 65536

Cooldude2606
Cooldude2606 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@Cooldude2606 Cooldude2606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All changes accounted for. Gui could be improved, but it works.

@Cooldude2606 Cooldude2606 merged commit ca25401 into explosivegaming:dev Dec 21, 2023
3 checks passed
@PHIDIAS0303 PHIDIAS0303 deleted the dev4 branch December 22, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cooldude2606 Cooldude2606 Cooldude2606 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PHIDIAS0303 @Cooldude2606