fixed using wrong package manager in yarn workspace projects #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also setup jest test so we can start building more tests
connectdotz
changed the title
…xpo#473) * Remove jest-expo plugin on eject and use jest-react-native instead * update jest.preset only when it is set to jest-expo * add warning message when jest-preset is updated to something different from jest-expo
* Update troubleshooting related to running a VPN * Update README.md
fson
reviewed
Mar 2, 2018
package.json
Outdated
| }, | ||
| "jest": { | ||
| "moduleFileExtensions": [ "js" ], | ||
| "testRegex": "(/__tests__/.*|\\.(test|spec))\\.(js)$", |
There was a problem hiding this comment.
I believe these are the default settings in Jest now, so we should be able to omit moduleFileExtensions and testRegex.
package.json
Outdated
| "moduleFileExtensions": [ "js" ], | ||
| "testRegex": "(/__tests__/.*|\\.(test|spec))\\.(js)$", | ||
| "testPathIgnorePatterns": [ | ||
| "\\.snap$", |
also setup jest test so we can start building more tests
…te-react-native-app into yarn-lookup-fix
|
done |
|
ping |
|
Hey, looks like something went wrong with merging changes from master. Could you please rebase this branch onto master? |
also setup jest test so we can start building more tests
…te-react-native-app into yarn-lookup-fix
|
rebased |
fson
added a commit
that referenced
this pull request
Mar 6, 2018
fixed using wrong package manager in yarn workspace projects
|
Thanks @connectdotz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to fix react-native-scripts not able to find
yarn.lockfile in the monorepo (workspaces) projects, which caused the react-native-scripts to use the wrong package manager and failed.yarn workspace project puts the
yarn.lockin the project root instead of the react native app directory. Since the current implementation only looks for yarn.lock in the app/cwd directory, it doesn't see the file and will wrongly select npm as the package manager. The new lookup method will traverse up the filesystem (similar to node module resolution) until it either finds the file or hits the filesystem root.outline the changes:
react-native-scripts/src/utils/pm.js, which performs the new logic described above.yarn testto guard against regression. Also updatedtaskfile.jsto exclude tests in the build.