feat: Upgrade knex to 1.x in @expo/entity-database-adapter-knex
#150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades knex to 1.x internally. This changes the behavior of `returning` but not in a way that affects how the knex adapter uses it: `returning('*')` behaves the same as before.
This does, however, change the TypeScript declarations for knex, which changed from:
```
Knex<TRecord extends {} = any, TResult = unknown[]>
```
to:
```
Knex<TRecord extends {} = any, TResult = Record<string, any>[]>
```
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
=======================================
Coverage 95.94% 95.94%
=======================================
Files 74 74
Lines 1874 1874
Branches 204 204
=======================================
Hits 1798 1798
Misses 75 75
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
wschurman
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why/How
Upgrades knex to 1.x internally. This changes the behavior of
returningbut not in a way that affects how the knex adapter uses it:returning('*')behaves the same as before.This does, however, change the TypeScript declarations for knex, which changed from:
to:
Test Plan
yarn test