BREAKING CHANGE: hoist the responsibility of sharing local memory cache adapter into application #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-6773.
The responsibility of defining the scope of how broadly or narrowly the shared cache should be shared should be the responsibility of the application. This way, the application can decide to share it amongst all requests or just have it be per-request (unlikely, but shouldn't be dictated by library).
Ref: https://github.com/expo/universe/pull/10701#pullrequestreview-1143120207
How
Make
localMemoryCacheAdapterMap
per-instance of theLocalMemoryCacheAdapterProvider
. Applications should create one instance of this provider per shared scope.Test Plan
Run tests.