Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update setField to correct typing #62

Merged
merged 1 commit into from
Jul 11, 2020

Conversation

wschurman
Copy link
Member

Why

4e40b2e incorrectly didn't update the set of fields that could be mutated for an entity that selects a subset of fields.

How

Update types.

Test Plan

yarn tsc

Use typeahead and see that only that entity's field subset are suggested.

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   94.07%   94.07%           
=======================================
  Files          58       58           
  Lines        1384     1384           
  Branches      147      147           
=======================================
  Hits         1302     1302           
  Misses         81       81           
  Partials        1        1           
Flag Coverage Δ
#integration 94.07% <100.00%> (ø)
#unittest 94.07% <100.00%> (ø)
Impacted Files Coverage Δ
packages/entity/src/EntityMutator.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c92d10...53aa62b. Read the comment docs.

@wschurman wschurman merged commit 7a77afc into master Jul 11, 2020
@wschurman wschurman deleted the @wschurman/fix-mutator-fieldset branch July 11, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant