feat: add entityClassName to metrics adapter events #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This adds the ability for concrete implementations of
IEntityMetricsAdapter
to segregate metric records by entity type. While not required (implementors can do whatever they like with the events), it may be helpful to find things like entity hot paths, slow tables, places that could use caches, etc.This is not a breaking change as the interface is an object so code that worked with the old interface should work with the new interface.
How
Add parameter to definition and pipe through to log events.
Test Plan
yarn test
(updated tests test the new behavior in addition to the old behavior to ensure no regressions).