Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Move xdl.UpdateVersions to expotools #2282

Closed
fson opened this issue Jun 18, 2020 · 0 comments · Fixed by #2387
Closed

Move xdl.UpdateVersions to expotools #2282

fson opened this issue Jun 18, 2020 · 0 comments · Fixed by #2387
Assignees
@tsapeta
Projects
Top Priorities

Comments

@fson
Copy link
Contributor

fson commented Jun 18, 2020 •
edited

This module is not used in Expo CLI at all, but at least UpdateVersions.updateIOSSimulatorBuild and UpdateVersions.updateAndroidApk are still used in expotools. We should move the code still in use to expotools and then delete this module from XDL.

cc @tsapeta
@fson fson mentioned this issue Jun 18, 2020
Merged
@tsapeta tsapeta self-assigned this Jul 20, 2020
@tsapeta tsapeta added this to To do in Top Priorities via automation Jul 20, 2020
This was referenced Jul 21, 2020
Merged
Merged
Top Priorities automation moved this from To do to Done Jul 24, 2020
tsapeta added a commit to expo/expo that referenced this issue Jul 29, 2020
@tsapeta
[et] Move UpdateVersions from xdl to expotools (#9336)
d56ff1c 
# Why

Part of expo/expo-cli#2282

# How

Moved some functionality of xdl's UpdateVersions to expotools and refactored `et client-build` command a little bit.

# Test Plan

Tested with `et client-build -p ios --release --skip-upload`, will test Android soon
barthap added a commit to expo/expo that referenced this issue Jul 31, 2020
@barthap
Squashed commit of the following:
215844a 
commit d56ff1c
Author: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com>
Date:   Wed Jul 29 11:49:15 2020 +0200

    [et] Move UpdateVersions from xdl to expotools (#9336)

    # Why

    Part of expo/expo-cli#2282

    # How

    Moved some functionality of xdl's UpdateVersions to expotools and refactored `et client-build` command a little bit.

    # Test Plan

    Tested with `et client-build -p ios --release --skip-upload`, will test Android soon

commit b5532de
Author: Michał Czernek <czernekmichal@gmail.com>
Date:   Wed Jul 29 11:13:45 2020 +0200

    [expo-module-template] Add unit tests in android module template.

commit fc7bc75
Author: Tomasz Sapeta <tsapeta@users.noreply.github.com>
Date:   Wed Jul 29 10:17:35 2020 +0200

    [bare-expo] Install pods

commit 9bca879
Author: Bartłomiej Klocek <bartlomiej.klocek@swmansion.com>
Date:   Wed Jul 29 10:03:05 2020 +0200

    [media-library] Fix `getAssetsAsync` crash when given invalid `after` value on Android (#9466)

    # Why

    Fixes #9440

    Non-number string values caused `Integer.parseInt()` throwing uncaught `NumberFormatException` in background thread - this crashed the whole application.

    # How

    Surrounded `parseInt()` within a `try-catch` block with fallback to default value.

    # Test Plan

    Tested `getAssetsAsync({after: ... })` for different string values (both valid and invalid) on Android emulator.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tsapeta tsapeta

Labels
None yet
Projects
No open projects
Top Priorities
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[xdl] Remove UpdateVersions from xdl expo/expo-cli
2 participants
@fson @tsapeta