Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

refactor(pkcs12): move to expo/expo #4794

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Dec 5, 2023

Why

See expo/expo#25766

How

  • Dropped from repo

Test Plan

No need.

byCedric added a commit to expo/expo that referenced this pull request Dec 11, 2023
# Why

Moving the actively used `@expo/pkcs12` over from `expo/expo-cli`.

Currently used in:
- `eas-cli`
- Our backend

Counter-part PR: expo/expo-cli#4794

# How

- Copied `@expo/pkcs12` from `expo/expo-cli`
- Updated `tsconfig.json` to point at this monorepo config
- Integrated `expo-module-scripts`
- Updated renamed types based on `@types/node@20`
- `HexBase64Latin1Encoding`
([code](https://github.com/expo/expo/pull/25766/files#diff-56cd7ede5693f24e527da29965345ceb880ec8a8967bab3a993cafdfe677e44dR113))
→ `BinaryToTextEncoding`
([types](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/68c795db12d031b4d16b13d6827571699571b9d4/types/node/crypto.d.ts#L390))
- `Utf8AsciiLatin1Encoding`
([code](https://github.com/expo/expo/pull/25766/files#diff-56cd7ede5693f24e527da29965345ceb880ec8a8967bab3a993cafdfe677e44dR109))
→ `Encoding`
([types](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/68c795db12d031b4d16b13d6827571699571b9d4/types/node/crypto.d.ts#L378))

# Test Plan

See if CI passes.

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
@byCedric byCedric merged commit dde5f78 into main Dec 11, 2023
@byCedric byCedric deleted the @bycedric/refactor/pkcs12 branch December 11, 2023 17:17
onizam95 pushed a commit to onizam95/expo-av-drm that referenced this pull request Jan 15, 2024
# Why

Moving the actively used `@expo/pkcs12` over from `expo/expo-cli`.

Currently used in:
- `eas-cli`
- Our backend

Counter-part PR: expo/expo-cli#4794

# How

- Copied `@expo/pkcs12` from `expo/expo-cli`
- Updated `tsconfig.json` to point at this monorepo config
- Integrated `expo-module-scripts`
- Updated renamed types based on `@types/node@20`
- `HexBase64Latin1Encoding`
([code](https://github.com/expo/expo/pull/25766/files#diff-56cd7ede5693f24e527da29965345ceb880ec8a8967bab3a993cafdfe677e44dR113))
→ `BinaryToTextEncoding`
([types](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/68c795db12d031b4d16b13d6827571699571b9d4/types/node/crypto.d.ts#L390))
- `Utf8AsciiLatin1Encoding`
([code](https://github.com/expo/expo/pull/25766/files#diff-56cd7ede5693f24e527da29965345ceb880ec8a8967bab3a993cafdfe677e44dR109))
→ `Encoding`
([types](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/68c795db12d031b4d16b13d6827571699571b9d4/types/node/crypto.d.ts#L378))

# Test Plan

See if CI passes.

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant