Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty array passed to SMS Addresses argument results in error on Android #2673

Closed
AdamJNavarro opened this issue Nov 9, 2018 · 1 comment
Closed

Empty array passed to SMS Addresses argument results in error on Android #2673

AdamJNavarro opened this issue Nov 9, 2018 · 1 comment
Labels
Android SMS

Comments

@AdamJNavarro
Copy link
Contributor

Android should be able to accept an empty array like iOS so that developers can use the API with the intended use of only providing a pre-populated message and letting their users determine what recipients they want to send the message to manually. As per this forum post: https://forums.expo.io/t/expo-31-android-sms-error-executing-exported-method-sendsmsasync-on-module-exposms/15758

Repro Snack: https://snack.expo.io/@adamjnav/YW5kcm
@mczernek mczernek mentioned this issue Mar 5, 2019
Merged
sjchmiela pushed a commit that referenced this issue Mar 6, 2019
@mczernek @sjchmiela
[expo-sms] Fix Android crash when empty addresses list provided to SM…
eeb907b 
…S.sendSMSAsync (#3656)

# Why

THis fixes issue [#2673](#2673) on Android, and provides consistent behavior for sending SMSes with empty addresses list between Android and iOS.

# Test Plan

SMSScreen in ncl now supports this scenario.
@esamelson
Copy link
Contributor

Looks like this was fixed by the commit referenced above ^, closing

@lock lock bot added the outdated label Apr 15, 2020
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Android SMS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AdamJNavarro @esamelson @expjess