@mczernek/expo sms/handle empty addresses array #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjchmiela
reviewed
Mar 5, 2019
packages/expo-sms/android/src/main/java/expo/modules/sms/SMSModule.java
Outdated
Show resolved
Hide resolved
packages/expo-sms/android/src/main/java/expo/modules/sms/SMSModule.java
Outdated
Show resolved
Hide resolved
packages/expo-sms/android/src/main/java/expo/modules/sms/SMSModule.java
Outdated
Show resolved
Hide resolved
tsapeta
requested changes
Mar 5, 2019
packages/expo-sms/android/src/main/java/expo/modules/sms/SMSModule.java
Outdated
Show resolved
Hide resolved
packages/expo-sms/android/src/main/java/expo/modules/sms/SMSModule.java
Outdated
Show resolved
Hide resolved
sjchmiela
reviewed
Mar 6, 2019
| private String constructRecipients(List<String> addresses) { | ||
| if (addresses.size() > 0) { | ||
| final StringBuilder addressesBuilder = new StringBuilder(addresses.get(0)); | ||
| for (String address: addresses) { |
There was a problem hiding this comment.
Suggested change
| for (String address: addresses) { | |
| for (String address : addresses) { |
I would suggest configuring Android Studio to format files on save. It has some downsides, like there are files in the project that aren't formatted and editing them will lead to unnecessary changes, but apart from that it's the easiest way to make sure files are formatted properly.
sjchmiela
reviewed
Mar 6, 2019
sjchmiela
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
THis fixes issue #2673 on Android, and provides consistent behavior for sending SMSes with empty addresses list between Android and iOS.
Test Plan
SMSScreen in ncl now supports this scenario.