Removed "_" prefix from partials

expressjs · Dec 10, 2010 · 2662dae · 2662dae
1 parent 6f6f9f0
commit 2662dae
Show file tree

Hide file tree

Showing 21 changed files with 6 additions and 19 deletions.
diff --git a/examples/cache/views/_user.ejs → examples/cache/views/user.ejs b/examples/cache/views/_user.ejs → examples/cache/views/user.ejs
diff --git a/examples/ejs/views/users/_user.ejs → examples/ejs/views/users/user.ejs b/examples/ejs/views/users/_user.ejs → examples/ejs/views/users/user.ejs
diff --git a/examples/flash/views/_messages.ejs → examples/flash/views/messages.ejs b/examples/flash/views/_messages.ejs → examples/flash/views/messages.ejs
diff --git a/examples/github/views/_repo.jade → examples/github/views/repo.jade b/examples/github/views/_repo.jade → examples/github/views/repo.jade
diff --git a/examples/jade/views/users/_user.jade → examples/jade/views/users/user.jade b/examples/jade/views/users/_user.jade → examples/jade/views/users/user.jade
diff --git a/examples/mvc/views/_messages.html → examples/mvc/views/messages.html b/examples/mvc/views/_messages.html → examples/mvc/views/messages.html
diff --git a/lib/express/view/partial.js b/lib/express/view/partial.js
@@ -29,7 +29,6 @@ var cache = {};
 var Partial = exports = module.exports = function Partial(view, options) {
   options = options || {};
   View.call(this, view, options);
-  this.path = this.resolvePartialPath(this.dirname);
 };
 
 /**
@@ -38,18 +37,6 @@ var Partial = exports = module.exports = function Partial(view, options) {
 
 Partial.prototype.__proto__ = View.prototype;
 
-/**
- * Resolve partial view path.
- *
- * @param {String} dir
- * @return {String}
- * @api public
- */
-
-Partial.prototype.resolvePartialPath = function(dir){
-  return dir + '/_' + basename(this.path);
-};
-
 /**
  * Resolve partial object name from the view path.
  *

diff --git a/test/fixtures/forum/_thread.jade → test/fixtures/forum/thread.jade b/test/fixtures/forum/_thread.jade → test/fixtures/forum/thread.jade
diff --git a/test/fixtures/_greetings.jade → test/fixtures/greeting.jade b/test/fixtures/_greetings.jade → test/fixtures/greeting.jade
diff --git a/test/fixtures/greetings.jade b/test/fixtures/greetings.jade
@@ -1,2 +1,2 @@
 h1= name
-!= partial('greetings', { locals: { name: otherName }})
+!= partial('greeting', { locals: { name: otherName }})
diff --git a/test/fixtures/_hello.ejs → test/fixtures/hello.ejs b/test/fixtures/_hello.ejs → test/fixtures/hello.ejs
diff --git a/test/fixtures/_item.jade → test/fixtures/item.jade b/test/fixtures/_item.jade → test/fixtures/item.jade
diff --git a/test/fixtures/_magic.jade → test/fixtures/magic.jade b/test/fixtures/_magic.jade → test/fixtures/magic.jade
diff --git a/test/fixtures/_movie.jade → test/fixtures/movie.jade b/test/fixtures/_movie.jade → test/fixtures/movie.jade
diff --git a/test/fixtures/_person.jade → test/fixtures/person.jade b/test/fixtures/_person.jade → test/fixtures/person.jade
diff --git a/test/fixtures/_pet-count.jade → test/fixtures/pet-count.jade b/test/fixtures/_pet-count.jade → test/fixtures/pet-count.jade
diff --git a/test/fixtures/_pet.jade → test/fixtures/pet.jade b/test/fixtures/_pet.jade → test/fixtures/pet.jade
diff --git a/test/fixtures/_user.jade → test/fixtures/user.jade b/test/fixtures/_user.jade → test/fixtures/user.jade
diff --git a/test/fixtures/user/_role.ejs → test/fixtures/user/role.ejs b/test/fixtures/user/_role.ejs → test/fixtures/user/role.ejs
diff --git a/test/fixtures/_video.jade → test/fixtures/video.jade b/test/fixtures/_video.jade → test/fixtures/video.jade
diff --git a/test/view.test.js b/test/view.test.js
@@ -106,19 +106,19 @@ module.exports = {
     var fixtures = __dirname + '/fixtures';
 
     var view = new Partial('user.jade', { root: fixtures });
-    view.path.should.equal(fixtures + '/_user.jade');
+    view.path.should.equal(fixtures + '/user.jade');
 
     var view = new Partial('user', { parentView: view, root: fixtures });
-    view.path.should.equal(fixtures + '/_user.jade');
+    view.path.should.equal(fixtures + '/user.jade');
 
     var view = new Partial('forum/thread', { parentView: view });
-    view.path.should.equal(fixtures + '/forum/_thread.jade');
+    view.path.should.equal(fixtures + '/forum/thread.jade');
 
     var view = new Partial('forum/thread.jade', { root: fixtures });
-    view.path.should.equal(fixtures + '/forum/_thread.jade');
+    view.path.should.equal(fixtures + '/forum/thread.jade');
 
     var view = new Partial('thread', { parentView: view });
-    view.path.should.equal(fixtures + '/forum/_thread.jade');
+    view.path.should.equal(fixtures + '/forum/thread.jade');
   },
 
   'test #render()': function(){