Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing res.location('back') tests #3292

Closed
WORMSS opened this issue Apr 27, 2017 · 2 comments
Closed

Missing res.location('back') tests #3292

WORMSS opened this issue Apr 27, 2017 · 2 comments
Assignees
@dougwilson
Labels
4.x pr tests

Comments

@WORMSS
Copy link
Contributor

WORMSS commented Apr 27, 2017

I had spotted there were no tests for res.location('back') so I have added them.

This is for a code split of #3290
WORMSS added a commit to WORMSS/express that referenced this issue Apr 27, 2017
@WORMSS
res.location back test
7676c4c 
A split of expressjs#3291 of just the tests.

Fixes expressjs#3292
This was referenced Apr 27, 2017
Closed
Open
@WORMSS
Copy link
Contributor Author

WORMSS commented May 5, 2017

Was there something extra I needed to do to this to get the test part of the split merged?

@dougwilson
Copy link
Contributor

Sorry, I forgot to finish off some tweaks. I made a couple tweaks to add some additional tests and put it into a "back" section.

@dougwilson dougwilson self-assigned this May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dougwilson dougwilson

Labels
4.x pr tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougwilson @WORMSS