Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file not found on default express install #4

Closed
mateodelnorte opened this issue Mar 25, 2014 · 5 comments
Closed

file not found on default express install #4

mateodelnorte opened this issue Mar 25, 2014 · 5 comments

Comments

@mateodelnorte
Copy link

just created a new express app using 3.5.0 and get the following:

Error: ENOENT, open '/Users/matt/development/knowjs/node_modules/express/node_modules/connect/node_modules/static-favicon/../public/favicon.ico'

this is using the standard, generated:

app.use(express.favicon());

which is exported from connect, which seems to just be a require('static-favicon'); ... which led me here. ;) let me know if this issue should go somewhere else.

Cheers and thanks for the great lib!

@defunctzombie
Copy link
Contributor

Just point it at a favicon file! Using the default favicon is silly anyway.

@mateodelnorte
Copy link
Author

Agreed, for this package. Perhaps Express should default install one for you instead of defaulting to an error.

@defunctzombie
Copy link
Contributor

We fixed this issue is master, I think we just need to update the dependency in express. I think there was a plan to make it throw if you didn't specify a path, otherwise just don't use the middleware if you don't have a favicon.

@mateodelnorte
Copy link
Author

Cool. Gracias.

@jonathanong
Copy link
Member

if there's no favicon, it should just return a 404. this would at least get rid of those issues where there are "multiple requests"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants