-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file not found on default express install #4
Comments
Just point it at a favicon file! Using the default favicon is silly anyway. |
Agreed, for this package. Perhaps Express should default install one for you instead of defaulting to an error. |
We fixed this issue is master, I think we just need to update the dependency in express. I think there was a plan to make it throw if you didn't specify a path, otherwise just don't use the middleware if you don't have a favicon. |
Cool. Gracias. |
if there's no favicon, it should just return a |
just created a new express app using 3.5.0 and get the following:
this is using the standard, generated:
which is exported from connect, which seems to just be a require('static-favicon'); ... which led me here. ;) let me know if this issue should go somewhere else.
Cheers and thanks for the great lib!
The text was updated successfully, but these errors were encountered: