Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small css "error" with tiles. #9

Closed
lukasoppermann opened this issue Sep 25, 2014 · 2 comments
Closed

Small css "error" with tiles. #9

lukasoppermann opened this issue Sep 25, 2014 · 2 comments
Labels

Comments

@lukasoppermann
Copy link

The tiles should not repeat (often one will add a screenshot or logo, so repeat makes no sense).
Also I thing the background-size: cover; is a bad idea, because it distorts the content.

My proposal:

        background-size: auto 100%;
        background-repeat: no-repeat;

But maybe it would be better to add the tile as an image tag, because this way one could make the images fill the space perfectly, but never scale to more than 100%. What do you think? Could that work for you?

@Exter-N
Copy link
Contributor

Exter-N commented Oct 1, 2014

Could you please show me a case where a tile repeats ?

If I understand the CSS spec correctly, "background-size: cover;" doesn't distort the content, it actually means "100% for one dimension, >= 100% for the other, preserve aspect ratio", which implies that the image cannot be repeated.

Regarding the use of an image tag to avoid upscaling, I'll try that when I'll find some time to spend on this package.

@Exter-N Exter-N self-assigned this Oct 1, 2014
@Exter-N Exter-N added this to the v0.3 milestone Oct 1, 2014
@lukasoppermann
Copy link
Author

Since I changed my css I can not show you. What happened was that it repeated not on the x but the y axis, so that there was a 1 px red line at the bottom. (In was using an image that has a red logo at the top but is black at the bottom.)

@Exter-N Exter-N removed this from the v0.3 milestone Jan 22, 2015
@lukasoppermann lukasoppermann removed this from the v0.3 milestone Jan 22, 2015
@GuilhemN GuilhemN added the bug label Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants