Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento-phpstan Action: Why do we need a composer package for it? Composer 2.0 is not supported! #49

Closed
trunglv opened this issue Dec 15, 2021 · 4 comments

Comments

@trunglv
Copy link

trunglv commented Dec 15, 2021

Hi, thank you for your great works here.
I would like to have 2 questions:

  1. Why do we need a composer package for it?
  2. Can you pls update a docker? so it can support Composer 2.0.
    Thank you so much!
@jissereitsma
Copy link
Contributor

Actually, the goal of ExtDN (under which this repository falls) has been to offer testing for third party extensions (ExtDN = Extension Developer Network). And composer is kind-of an essential requirement for offering an extension to others. Are you bumping into issues because of this?

As for composer 2 support, indeed this is still missing. It was pending another PR https://github.com/extdn/github-actions-m2/pull/40/files which we wanted to await first. Let me see if I can fix this quickly here as well.

@jissereitsma
Copy link
Contributor

Added composer 2 support, even though the default is still composer 1. The following example explains how to enable composer 2 with the flag COMPOSER_VERSION: https://github.com/extdn/github-actions-m2/blob/master/examples/extdn-phpstan.yml I didn't check if this is fully working yet though ....

@trunglv
Copy link
Author

trunglv commented Dec 16, 2021

Hi @jissereitsma. Thank you. Yes, I checked again, it worked well with packages on Composer 2.0.

Actually, the goal of ExtDN (under which this repository falls) has been to offer testing for third party extensions (ExtDN = Extension Developer Network). And composer is kind-of an essential requirement for offering an extension to others. Are you bumping into issues because of this?
=> It's good idea. I have an issue that makes the testing work with private Repo. Your Github action is very super good to get started. I will learn from it and bring it to an adjustment version that works on private Repo.

@jissereitsma
Copy link
Contributor

I'm closing this ticket for now. Let me know if it needs to be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants