-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add use_rng
option to attribute macro extendr
.
#476
Conversation
`use module::get_module_metadata`.
the trait `GetSexp`.
`extendr`.
First, CI is going to keep failing unless the libR-sys PRs are merged. |
You can depend on the specific branch of libR-sys if we keep the pull requests on libR-sys unmerged (But, the runners without bindgen would still fail). Line 13 in 974cddc
extendr/.github/workflows/test.yml Line 271 in 974cddc
|
isn't it enough that I've mirror all of these to my own github and tested
that it works out?
…On Wed, Feb 8, 2023 at 3:14 PM Hiroaki Yutani ***@***.***> wrote:
You can depend on the specific branch of libR-sys if we keep the pull
requests on libR-sys unmerged (But, the runners without bindgen would still
fail).
https://github.com/extendr/extendr/blob/974cddc4ee5a4c3ab10e8bf85772b74c0a182f32/Cargo.toml#L13
https://github.com/extendr/extendr/blob/974cddc4ee5a4c3ab10e8bf85772b74c0a182f32/.github/workflows/test.yml#L271
https://github.com/extendr/extendr/blob/974cddc4ee5a4c3ab10e8bf85772b74c0a182f32/tests/extendrtests/src/rust/Cargo.toml#L33
—
Reply to this email directly, view it on GitHub
<#476 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIDVSBIUSDLO66T43NLYPDWWOS5ZANCNFSM6AAAAAAUR6WRNQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
It's fine if you are fine. |
Actually, I think this is very good instruction. I think it should be in the contributor guide or something. Thanks for the tip.. I didn't understand it at first. I'll write a contributor-guide PR with this in it for prosperity. |
* Started documenting the `#[extendr]` proc-macro * fixes the need for `use module::get_module_metadata`. * Revert some changes * Added an integration test. * Fixed the need to import the trait `GetSexp`. * expanded the test with an adjacent module * This should now force the extendrtests to test this bug
* Add `CollectRArray` trait * Document RArray::new_matrix()
* Document the robj_ndarray module * Add conversion for owned arrays, with tests
Added `use_rng` to attribute macro `extendr`. Added to change-log not done~
…into extendr_rng_state
Moved to #488 due to merging chaos. |
Fixes #474.
But depends on extendr/libR-sys#123 and corresponding
generated_bindings
pr before merging this.I tested this on my forks of this, and you can too!
This also depends on #469.