Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demonstrating #3097

Closed
wants to merge 1 commit into from
Closed

Demonstrating #3097

wants to merge 1 commit into from

Conversation

shuheiktgw
Copy link
Contributor

Problem Statement

I'll close this PR later. This is for #3077

Related Issue

Fixes #...

Proposed Changes

How do you like to solve the issue and why?

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@shuheiktgw shuheiktgw requested a review from a team as a code owner February 1, 2024 23:29
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shuheiktgw shuheiktgw mentioned this pull request Feb 1, 2024
Merged
5 tasks
@shuheiktgw shuheiktgw closed this Feb 1, 2024
@shuheiktgw shuheiktgw deleted the demo-ready-condition-early branch February 1, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knelasevero knelasevero Awaiting requested review from knelasevero knelasevero is a code owner automatically assigned from external-secrets/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shuheiktgw