Feat/ready condition early

[ppatel1604]

Problem Statement

As per suggestion in #3029, ClusterExternalSecrets never report ready until the controller has created an ExternalSecret in a targeted namespace.

Related Issue

Fixes #3029

Proposed Changes

As mentioned in the #3029, setting the condition to be Ready even when No namespace exist. The condition will not be ready only when there is a failed namespace

Checklist

• I have read the contribution guidelines
• All commits are signed with git commit --signoff
• My changes have reasonable test coverage
• All tests pass with make test
• I ensured my PR is ready for review with make reviewable

[shuheiktgw]

Thanks for your interest in contributing to the project. Instead of leaving comments here and there, I've created a PR to demonstrate how we could tackle the problem to save some time, so please take a look at it 🙂 Please note that we also need to update tests.

#3097

[shuheiktgw]

Why do we need the two lines above? 🤔

[ppatel1604]

Thank you for the review and suggestion @shuheiktgw . I have removed these lines.

[ppatel1604]

Thanks for your interest in contributing to the project. Instead of leaving comments here and there, I've created a PR to demonstrate how we could tackle the problem to save some time, so please take a look at it 🙂 Please note that we also need to update tests.

#3097

@shuheiktgw Thank you for your guidance. It looks good to me. I will raise update the PR shortly with suggested changes, including updated unit tests.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

[shuheiktgw]

LGTM, thanks!