issue/3153 - added missing snapshots for Pulumi and Chef crd tests #3154

fdberlking · 2024-02-15T20:38:14Z

Problem Statement

Fixing failing Helm tests for crds due to missing snaps for Chef and Pulumi.

Related Issue

Proposed Changes

Adding missing snaps for both crds.

➜  external-secrets git:(issue/3153) make helm.test            
./hack/helm.generate.sh deploy/crds deploy/charts/external-secrets
21:34:22 [ OK ] Finished generating helm chart files

### Chart [ external-secrets ] deploy/charts/external-secrets/

 PASS  test cert controller deployment  deploy/charts/external-secrets/tests/cert_controller_test.yaml
 PASS  test controller deployment       deploy/charts/external-secrets/tests/controller_test.yaml
 PASS  test crds        deploy/charts/external-secrets/tests/crds_test.yaml
 PASS  test service monitor     deploy/charts/external-secrets/tests/service_monitor_test.yaml
 PASS  test webhook deployment  deploy/charts/external-secrets/tests/webhook_test.yaml

Charts:      1 passed, 1 total
Test Suites: 5 passed, 5 total
Tests:       39 passed, 39 total
Snapshot:    5 passed, 5 total
Time:        437.509589ms

Checklist

I have read the contribution guidelines
All commits are signed with git commit --signoff
My changes have reasonable test coverage
All tests pass with make test
I ensured my PR is ready for review with make reviewable

Signed-off-by: Benjamin Walterscheid <benjamin.walterscheid@de.ibm.com>

sonarcloud · 2024-02-15T20:38:50Z

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://togithub.com/external-secrets/external-secrets) | patch | `0.9.12` -> `0.9.13` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.9.13`](https://togithub.com/external-secrets/external-secrets/releases/tag/v0.9.13) [Compare Source](https://togithub.com/external-secrets/external-secrets/compare/v0.9.12...v0.9.13) Image: `ghcr.io/external-secrets/external-secrets:v0.9.13` Image: `ghcr.io/external-secrets/external-secrets:v0.9.13-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.9.13-ubi-boringssl` #### What's Changed - bump 0.9.12 by [@rogertuma](https://togithub.com/rogertuma) in [external-secrets/external-secrets#3125 - temporarily removing ossf checks for helm release by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [external-secrets/external-secrets#3128 - chore(deps): bump aquasecurity/trivy-action from [`f3d9851`](https://togithub.com/external-secrets/external-secrets/commit/f3d98514b056d8c71a3552e8328c225bc7f6f353) to [`84384bd`](https://togithub.com/external-secrets/external-secrets/commit/84384bd6e777ef152729993b8145ea352e9dd3ef) by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3142 - chore(deps): bump ubi8/ubi-minimal from `c9c8f91` to `6825946` by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3137 - feat: add push secret to e2e tests by [@Skarlso](https://togithub.com/Skarlso) in [external-secrets/external-secrets#3017 - Implementation of Chef External Secrets Provider by [@sourav977](https://togithub.com/sourav977) in [external-secrets/external-secrets#3127 - feat: add support for Pulumi ESC by [@dirien](https://togithub.com/dirien) in [external-secrets/external-secrets#2997 - chore(deps): bump watchdog from 3.0.0 to 4.0.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3134 - chore(deps): bump certifi from 2023.11.17 to 2024.2.2 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3135 - chore(deps): bump mkdocs-material from 9.5.7 to 9.5.9 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3136 - chore(deps): bump golang from 1.21.6 to 1.22.0 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3138 - chore(deps): bump golangci/golangci-lint-action from 3.7.0 to 4.0.0 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3140 - chore(deps): bump golang from 1.21.6-bookworm to 1.22.0-bookworm in /e2e by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3139 - chore(deps): bump helm/kind-action from 1.8.0 to 1.9.0 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3141 - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [external-secrets/external-secrets#3143 - Start the helm workflow when files in deploy/crds change by [@shuheiktgw](https://togithub.com/shuheiktgw) in [external-secrets/external-secrets#3098 - Implements Webhook Generator by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [external-secrets/external-secrets#3121 - Run unit tests on the main branch by [@shuheiktgw](https://togithub.com/shuheiktgw) in [external-secrets/external-secrets#3126 - fix(docs): Fix indentation in `vault-pushsecret.yaml` by [@mboutet](https://togithub.com/mboutet) in [external-secrets/external-secrets#3156 - issue/3153 - added missing snapshots for Pulumi and Chef crd tests by [@fdberlking](https://togithub.com/fdberlking) in [external-secrets/external-secrets#3154 #### New Contributors - [@sourav977](https://togithub.com/sourav977) made their first contribution in [external-secrets/external-secrets#3127 - [@dirien](https://togithub.com/dirien) made their first contribution in [external-secrets/external-secrets#2997 - [@mboutet](https://togithub.com/mboutet) made their first contribution in [external-secrets/external-secrets#3156 **Full Changelog**: external-secrets/external-secrets@v0.9.12...v0.9.13 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://togithub.com/external-secrets/external-secrets) | patch | `0.9.12` -> `0.9.13` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.9.13`](https://togithub.com/external-secrets/external-secrets/releases/tag/v0.9.13) [Compare Source](https://togithub.com/external-secrets/external-secrets/compare/v0.9.12...v0.9.13) Image: `ghcr.io/external-secrets/external-secrets:v0.9.13` Image: `ghcr.io/external-secrets/external-secrets:v0.9.13-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.9.13-ubi-boringssl` #### What's Changed - bump 0.9.12 by [@rogertuma](https://togithub.com/rogertuma) in [external-secrets/external-secrets#3125 - temporarily removing ossf checks for helm release by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [external-secrets/external-secrets#3128 - chore(deps): bump aquasecurity/trivy-action from [`f3d9851`](https://togithub.com/external-secrets/external-secrets/commit/f3d98514b056d8c71a3552e8328c225bc7f6f353) to [`84384bd`](https://togithub.com/external-secrets/external-secrets/commit/84384bd6e777ef152729993b8145ea352e9dd3ef) by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3142 - chore(deps): bump ubi8/ubi-minimal from `c9c8f91` to `6825946` by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3137 - feat: add push secret to e2e tests by [@Skarlso](https://togithub.com/Skarlso) in [external-secrets/external-secrets#3017 - Implementation of Chef External Secrets Provider by [@sourav977](https://togithub.com/sourav977) in [external-secrets/external-secrets#3127 - feat: add support for Pulumi ESC by [@dirien](https://togithub.com/dirien) in [external-secrets/external-secrets#2997 - chore(deps): bump watchdog from 3.0.0 to 4.0.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3134 - chore(deps): bump certifi from 2023.11.17 to 2024.2.2 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3135 - chore(deps): bump mkdocs-material from 9.5.7 to 9.5.9 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3136 - chore(deps): bump golang from 1.21.6 to 1.22.0 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3138 - chore(deps): bump golangci/golangci-lint-action from 3.7.0 to 4.0.0 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3140 - chore(deps): bump golang from 1.21.6-bookworm to 1.22.0-bookworm in /e2e by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3139 - chore(deps): bump helm/kind-action from 1.8.0 to 1.9.0 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3141 - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [external-secrets/external-secrets#3143 - Start the helm workflow when files in deploy/crds change by [@shuheiktgw](https://togithub.com/shuheiktgw) in [external-secrets/external-secrets#3098 - Implements Webhook Generator by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [external-secrets/external-secrets#3121 - Run unit tests on the main branch by [@shuheiktgw](https://togithub.com/shuheiktgw) in [external-secrets/external-secrets#3126 - fix(docs): Fix indentation in `vault-pushsecret.yaml` by [@mboutet](https://togithub.com/mboutet) in [external-secrets/external-secrets#3156 - issue/3153 - added missing snapshots for Pulumi and Chef crd tests by [@fdberlking](https://togithub.com/fdberlking) in [external-secrets/external-secrets#3154 #### New Contributors - [@sourav977](https://togithub.com/sourav977) made their first contribution in [external-secrets/external-secrets#3127 - [@dirien](https://togithub.com/dirien) made their first contribution in [external-secrets/external-secrets#2997 - [@mboutet](https://togithub.com/mboutet) made their first contribution in [external-secrets/external-secrets#3156 **Full Changelog**: external-secrets/external-secrets@v0.9.12...v0.9.13 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>

…ternal-secrets#3154) Signed-off-by: Benjamin Walterscheid <benjamin.walterscheid@de.ibm.com> Co-authored-by: Benjamin Walterscheid <benjamin.walterscheid@de.ibm.com>

issue/3153 - added missing snapshot for Pulumi and Chef crd tests

b86148e

Signed-off-by: Benjamin Walterscheid <benjamin.walterscheid@de.ibm.com>

fdberlking requested a review from a team as a code owner February 15, 2024 20:38

fdberlking requested a review from sebagomez February 15, 2024 20:38

fdberlking mentioned this pull request Feb 15, 2024

Correct failing crds helm.tests for providers Chef & Pulumi #3153

Closed

gusfcarvalho approved these changes Feb 17, 2024

View reviewed changes

gusfcarvalho merged commit 79b42bd into external-secrets:main Feb 17, 2024
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

issue/3153 - added missing snapshots for Pulumi and Chef crd tests #3154

issue/3153 - added missing snapshots for Pulumi and Chef crd tests #3154

fdberlking commented Feb 15, 2024 •

edited

sonarcloud bot commented Feb 15, 2024

issue/3153 - added missing snapshots for Pulumi and Chef crd tests #3154

issue/3153 - added missing snapshots for Pulumi and Chef crd tests #3154

Conversation

fdberlking commented Feb 15, 2024 • edited

Problem Statement

Related Issue

Proposed Changes

Checklist

sonarcloud bot commented Feb 15, 2024

Quality Gate passed

fdberlking commented Feb 15, 2024 •

edited