feat: add push secret to e2e tests

[Skarlso]

Problem Statement

What is the problem you're trying to solve?

Related Issue

Details about the edit. The refactor now includes a different setup for tests using PushSecret. The reason why it's separate from the ExternalSecret things is because it requires different things as a source. For example, it requires a source secret to exist in Kubernetes.

The proof, however, is a bit difficult. I included a sample test case under e2e/suites/provider/cases/template/template.go. The only way to prove that PushSecret succeeded in what it wanted to push is by either checking if the Status of the push secret is a success, as in condition Ready is true, or by using ANOTHER ExternalSecret to fetch the value that the push secret created.

I'm debating baking that into the default test case, but you might not want to do that based on your scenario.

That said, if the need arises, we can always refactor it and include the ExternalSecret part into the default test case setup to make the actual test case leaner.

Proposed Changes

How do you like to solve the issue and why?

Checklist

• I have read the contribution guidelines
• All commits are signed with git commit --signoff
• My changes have reasonable test coverage
• All tests pass with make test
• I ensured my PR is ready for review with make reviewable

[Skarlso]

Go home Sonar, you're drunk.

10
New Issues
New issues introduced by your PR

[Skarlso]

Hm, I don't have a nice way of verifying the outcome 🤔

[Skarlso]

I could create the whole flow. Create an external secret that pulls the secret the push secret just created. And check the value is the templates value. Since in the e2e test I don't have direct access to the fake provider. But that's at least a nice e2e flow I guess.

[Skarlso]

It's wooorrrkiiingg!! 🎉 🎉

[Skarlso]

Ran 3 of 278 Specs in 35.139 seconds
SUCCESS! -- 3 Passed 

[shuheiktgw]

I left one minor comment, but overall I think this looks like a good place to start with 👍

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

[knelasevero]

awesome!