Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update namespace of Extism functions #504

Closed
27 of 30 tasks
zshipko opened this issue Oct 10, 2023 · 1 comment
Closed
27 of 30 tasks

Update namespace of Extism functions #504

zshipko opened this issue Oct 10, 2023 · 1 comment
Assignees
@zshipko
Labels
enhancement New feature or request

Comments

@zshipko
Copy link
Contributor

zshipko commented Oct 10, 2023 •
edited

Currently we use the env namespace and prefix our functions with extism_, we should be using a proper namespace, like extism:host/env instead. So instead of env::extism_alloc, we could use extism:host/env::alloc.

For user-defined host functions we should defined to extism:host/user

Plan

  • Merge Go-SDK changes, test the PDK PRs with an update extism CLI
  • Merge the PDKs, plugins
    • Dotnet PDK
    • JS PDK
  • Merge the runtime
  • Merge the SDKs
  • Update js-sdk
  • Merge EIP
@zshipko zshipko added the enhancement New feature or request label Oct 10, 2023
This was referenced Oct 11, 2023
Merged
Merged
@zshipko zshipko mentioned this issue Oct 13, 2023
Merged
@zshipko zshipko self-assigned this Oct 13, 2023
This was referenced Oct 13, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@nilslice nilslice mentioned this issue Oct 16, 2023
Open
This was referenced Oct 19, 2023
Closed
Merged
Merged
zshipko added a commit that referenced this issue Oct 30, 2023
@zshipko @github-actions
refactor!: Use extism:host/env namespace for extism functions and `…
f3447a5 
…extism:host/user` for user-defined host functions (#511)

See #504 

Removes CI for the in-repo SDKs, we can remove the actual code closer to
the 1.0 release.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: zshipko <zshipko@users.noreply.github.com>
zshipko added a commit to extism/go-sdk that referenced this issue Oct 30, 2023
@mhmd-azeez @zshipko
feat: move extism functions to extism:host/env namespace (#31)
8391ea7 
This part of the extism/extism/issues/504 effort to move extism
functions to `extism::env`. For backward compatibility reasons, I am
also registering the functions in the `env` namespace.

---------

Co-authored-by: zach <zach@dylibso.com>
zshipko added a commit to extism/python-sdk that referenced this issue Oct 30, 2023
@zshipko
chore: update to use new extism namespaces (#13)
d983184 
See extism/extism#504
zshipko added a commit to extism/java-sdk that referenced this issue Oct 31, 2023
@zshipko
chore: use extism/host:env namespace (#11)
20deae8 
See extism/extism#504
@zshipko zshipko mentioned this issue Nov 3, 2023
Closed
@neuronicnobody
Copy link
Contributor

New issue opened for the JS SDK. Will track remaining work there

@mhmd-azeez mhmd-azeez mentioned this issue Nov 8, 2023
Merged
mhmd-azeez added a commit to extism/go-sdk that referenced this issue Nov 9, 2023
@mhmd-azeez
fix: set default host function namespace to extism:host/user (#37)
d502225 
See extism/extism/issues/504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zshipko zshipko

Labels
enhancement New feature or request
Projects
Extism 1.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zshipko @neuronicnobody