refactor!: Use extism:host/env namespace for extism functions and extism:host/user for user-defined host functions
#511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zshipko
added a commit
that referenced
this pull request
Oct 13, 2023
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #511 Co-authored-by: zshipko <zshipko@users.noreply.github.com>
30 tasks
|
Since the SDKs have mostly been moved to new repos, I'm not going to update the failing SDK tests. Instead, maybe this PR should include the changes to remove the old SDKs from this repo, since we will likely merge this closer to the planned 1.0 release date. |
zshipko
added a commit
that referenced
this pull request
Oct 17, 2023
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #511 Co-authored-by: zshipko <zshipko@users.noreply.github.com>
zshipko
added a commit
that referenced
this pull request
Oct 17, 2023
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #511 Co-authored-by: zshipko <zshipko@users.noreply.github.com>
zshipko
added a commit
that referenced
this pull request
Oct 18, 2023
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #511 Co-authored-by: zshipko <zshipko@users.noreply.github.com>
zshipko
added a commit
that referenced
this pull request
Oct 18, 2023
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #511 Co-authored-by: zshipko <zshipko@users.noreply.github.com>
runtime/src/plugin.rs
Outdated
| @@ -2,6 +2,9 @@ use std::collections::BTreeMap; | |||
|
|
|||
| use crate::*; | |||
|
|
|||
| pub const EXTISM_ENV_MODULE: &str = "extism:env"; | |||
| pub const EXTISM_USER_MODULE: &str = "extism:user"; | |||
There was a problem hiding this comment.
winces Ack, sorry sorry. I think we might want to add an interface projection here, too: something like extism:core/env / extism:core/user. Mea culpa here – I ran into this with the observe-api component model support. (The /foo bit maps to an interface in WIT.)
There was a problem hiding this comment.
Thanks for catching this!!! I think I will go with extism:host/env and extism:host/user
zshipko
changed the title
extism:env namespace for extism functionsextism:host/env namespace for extism functions and extism:host/user for user-defined host functions
zshipko
added a commit
that referenced
this pull request
Oct 20, 2023
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #511 Co-authored-by: zshipko <zshipko@users.noreply.github.com>
zshipko
added a commit
that referenced
this pull request
Oct 24, 2023
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #511 Co-authored-by: zshipko <zshipko@users.noreply.github.com>
zshipko
force-pushed
the
extism-env
branch
2 times, most recently
from
55a052a
to
ed70d53
Compare
zshipko
added a commit
that referenced
this pull request
Oct 25, 2023
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #511 Co-authored-by: zshipko <zshipko@users.noreply.github.com>
zshipko
added a commit
that referenced
this pull request
Oct 25, 2023
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #511 Co-authored-by: zshipko <zshipko@users.noreply.github.com>
zshipko
added a commit
that referenced
this pull request
Oct 26, 2023
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #511 Co-authored-by: zshipko <zshipko@users.noreply.github.com>
zshipko
added a commit
that referenced
this pull request
Oct 26, 2023
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #511 Co-authored-by: zshipko <zshipko@users.noreply.github.com>
…namespace changes
…g after namespace changes" This reverts commit 1c4744d.
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #511 Co-authored-by: zshipko <zshipko@users.noreply.github.com>
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #511 Co-authored-by: zshipko <zshipko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #504
Removes CI for the in-repo SDKs, we can remove the actual code closer to the 1.0 release.