Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import extism functions from extism:host/env #16

Merged
merged 9 commits into from
Oct 31, 2023

Conversation

mhmd-azeez
Copy link
Collaborator

This part of the extism/extism/issues/504 effort to move extism functions to extism::env. I have tested this with a modified go-sdk

@zshipko
Copy link
Contributor

zshipko commented Oct 11, 2023

@chrisdickinson had suggested extism:env as the namespace, is there any reason why extism would be an issue Chris? I am not totally aware of all the wit/component model naming conventions.

@mhmd-azeez
Copy link
Collaborator Author

Ah, it seems like I have misread it as extism::env. will push a fix

@mhmd-azeez mhmd-azeez changed the title feat: import extism functions from extism::env feat: import extism functions from extism:env Oct 11, 2023
@mhmd-azeez
Copy link
Collaborator Author

The tests are expected to fail until the runtimes are updated to support the new namespace

@zshipko zshipko changed the title feat: import extism functions from extism:env feat: import extism functions from extism:host/env Oct 20, 2023
@zshipko
Copy link
Contributor

zshipko commented Oct 30, 2023

@mhmd-azeez the runtimes have been updated, does this need some additional changes still?

@mhmd-azeez
Copy link
Collaborator Author

@zshipko fixed the tests, feel free to merge the PR

@zshipko zshipko merged commit c55f3de into main Oct 31, 2023
1 check passed
@mhmd-azeez mhmd-azeez deleted the feat/rename-namespace branch November 1, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants