cleanup: improve wat detection #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let s = std::str::from_utf8(&data); | ||
| let is_wat = s.is_ok_and(|data| { | ||
| let data = data.trim_start(); | ||
| data.starts_with("(module") || data.starts_with(";;") |
There was a problem hiding this comment.
(Ooh, this could also start with (;)
There was a problem hiding this comment.
ah thanks! i will open a new PR and link here. would (; be the start of a comment inside the opening paren?
There was a problem hiding this comment.
It's a block comment (there's an example over here!)
There was a problem hiding this comment.
also, would a paren followed by whitespace be valid? something like this:
(
moduleedit: looks like it is and that '(;' is a block comment (which i didn't even know existed!), sorry for the noise
zshipko
added a commit
that referenced
this pull request
Jan 5, 2024
Merged the other one too quickly, this PR is updated with some additional feedback from @chrisdickinson: (Ooh, this could also start with `(;`) #650 (comment) It's also updated to accommodate for modules that start with an open paren followed by some whitespace. I doubt this covers all of the permitted syntax but it should be good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_watis only true when the input is a valid string