Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: improve wat detection (again) #651

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Jan 5, 2024

Merged the other one too quickly, this PR is updated with some additional feedback from @chrisdickinson:

          (Ooh, this could also start with `(;`)

#650 (comment)

It's also updated to accommodate for modules that start with an open paren followed by some whitespace. I doubt this covers all of the permitted syntax but it should be good enough.

Copy link
Contributor

@chrisdickinson chrisdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zshipko zshipko merged commit 431bc4d into main Jan 5, 2024
5 checks passed
@zshipko zshipko deleted the improve-wat-detection2 branch January 5, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants