Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dev dependencies #51

Open
luceos opened this issue Apr 28, 2017 · 5 comments
Open

Drop dev dependencies #51

luceos opened this issue Apr 28, 2017 · 5 comments

Comments

@luceos
Copy link
Member

luceos commented Apr 28, 2017

Anyone using bazaar most likely does not need any dev dependencies, let's not install those in our vendor.

@clarkwinkelmann
Copy link
Contributor

Well, that's why they are called dev dependencies!

People should install bazaar with --no-dev / --update-no-dev flag

Bazaar itself already runs composer in production mode. (It's not clearly visible because it's the default behavior; in the official composer CLI the absence of the --no-dev flags sets the setDevMode(). Example: https://github.com/composer/composer/blob/master/src/Composer/Command/InstallCommand.php#L104)

@luceos
Copy link
Member Author

luceos commented Apr 28, 2017

I meant that bazaar should install packages without including dev dependencies by default. I wasn't specifically talking about installing bazaar 😁

@clarkwinkelmann
Copy link
Contributor

It's not working then? It should 😅

@luceos
Copy link
Member Author

luceos commented Apr 28, 2017

It's not about dist mode, it's about dev mode:

https://github.com/composer/composer/blob/master/src/Composer/Command/InstallCommand.php#L105

@luceos
Copy link
Member Author

luceos commented Apr 28, 2017

Oh that's what you said too, but doesn't composer set dev mode if left out.. Seems like it doesn't. We'd have to confirm this anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants