Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule Support #1087

Closed
DctrNoob opened this issue Jan 22, 2022 · 7 comments
Closed

Submodule Support #1087

DctrNoob opened this issue Jan 22, 2022 · 7 comments
Assignees
Milestone

Comments

@DctrNoob
Copy link

I'd really like to see submodule support, i.e. updating and navigating into and out of submodules connected to the main repository. My most common use case is to invoke git submodule update --init --recursive after a git pull. Of course, once you navigate into a submodule, this module is just another repo and the normal gitui applies.

@extrawurst
Copy link
Owner

extrawurst commented Jan 22, 2022

so I would understand this as multiple feature requests, correct me if I am wrong:

  1. update all submodules recursively
  2. list submodules
  3. navigate into a submodule (essentially spawning a new gitui inside the submodule) (see upstream)
  4. revert submodule changes (see upstream)

@DctrNoob
Copy link
Author

Sounds about right. Didn't really think this through so it's likely I am missing vital aspects.

@extrawurst extrawurst added this to the v0.21 milestone Jan 25, 2022
@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the dormant Marked by stale bot on close label Jul 30, 2022
@extrawurst extrawurst removed the dormant Marked by stale bot on close label Aug 17, 2022
@extrawurst extrawurst self-assigned this Aug 17, 2022
@extrawurst extrawurst modified the milestones: v0.21, v0.22 Aug 17, 2022
@extrawurst
Copy link
Owner

@DctrNoob I got a prof of concept in the PR working. but in order for this to be properly tested I'd like a test case that comes with a ton of submodules. got a good open source git repo for this to be tested in?

@extrawurst
Copy link
Owner

Screenshot 2022-08-27 at 14 16 21

@DctrNoob
Copy link
Author

Try this one, it has ~10 submodules: https://github.com/mmp/pbrt-v4

@extrawurst
Copy link
Owner

extrawurst commented Aug 27, 2022

Screenshot 2022-08-27 at 17 52 09

Now we have a PoC on master.

TODO:

  • update submodule
  • open submodule in gitui
  • support going to parent repo

This was referenced Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants