Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excessive tags fetching in revlog #850

Closed
extrawurst opened this issue Aug 17, 2021 · 0 comments · Fixed by #851
Closed

excessive tags fetching in revlog #850

extrawurst opened this issue Aug 17, 2021 · 0 comments · Fixed by #851
Labels
bug Something isn't working
Milestone

Comments

@extrawurst
Copy link
Owner

scrolling up and down the revlog I noticed that an excessive amount of git fetching happens which slows down the app:

10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::utils::get_head_repo] @asyncgit/src/sync/utils.rs:106
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::utils::get_head_repo] @asyncgit/src/sync/utils.rs:106
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 2 ms [asyncgit::sync::state::repo_state] @asyncgit/src/sync/state.rs:28
10:37:03 [TRACE] (2) scopetime: [scopetime/src/lib.rs:41] scopetime: 9 ms [asyncgit::sync::tags::get_tags] @asyncgit/src/sync/tags.rs:29
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 32 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 1 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 2 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 2 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (1) gitui::app: [src/app.rs:263] event: Input(Key(KeyEvent { code: Down, modifiers: NONE }))
10:37:03 [TRACE] (1) asyncgit::tags: [asyncgit/src/tags.rs:67] request
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::utils::get_head_repo] @asyncgit/src/sync/utils.rs:106
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::utils::get_head_repo] @asyncgit/src/sync/utils.rs:106
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::state::repo_state] @asyncgit/src/sync/state.rs:28
10:37:03 [TRACE] (2) scopetime: [scopetime/src/lib.rs:41] scopetime: 5 ms [asyncgit::sync::tags::get_tags] @asyncgit/src/sync/tags.rs:29
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 8 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 1 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (1) gitui::app: [src/app.rs:263] event: Input(Key(KeyEvent { code: Down, modifiers: NONE }))
10:37:03 [TRACE] (1) asyncgit::tags: [asyncgit/src/tags.rs:67] request
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::utils::get_head_repo] @asyncgit/src/sync/utils.rs:106
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::utils::get_head_repo] @asyncgit/src/sync/utils.rs:106
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::state::repo_state] @asyncgit/src/sync/state.rs:28
10:37:03 [TRACE] (2) scopetime: [scopetime/src/lib.rs:41] scopetime: 7 ms [asyncgit::sync::tags::get_tags] @asyncgit/src/sync/tags.rs:29
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 29 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 1 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (1) gitui::app: [src/app.rs:263] event: Input(Key(KeyEvent { code: Up, modifiers: NONE }))
10:37:03 [TRACE] (1) asyncgit::tags: [asyncgit/src/tags.rs:67] request
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::utils::get_head_repo] @asyncgit/src/sync/utils.rs:106
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::utils::get_head_repo] @asyncgit/src/sync/utils.rs:106
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::state::repo_state] @asyncgit/src/sync/state.rs:28
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 4 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (2) scopetime: [scopetime/src/lib.rs:41] scopetime: 5 ms [asyncgit::sync::tags::get_tags] @asyncgit/src/sync/tags.rs:29
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 1 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (1) gitui::app: [src/app.rs:263] event: Input(Key(KeyEvent { code: Up, modifiers: NONE }))
10:37:03 [TRACE] (1) asyncgit::tags: [asyncgit/src/tags.rs:67] request
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::utils::get_head_repo] @asyncgit/src/sync/utils.rs:106
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::utils::get_head_repo] @asyncgit/src/sync/utils.rs:106
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::state::repo_state] @asyncgit/src/sync/state.rs:28
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 6 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (2) scopetime: [scopetime/src/lib.rs:41] scopetime: 6 ms [asyncgit::sync::tags::get_tags] @asyncgit/src/sync/tags.rs:29
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 1 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (1) gitui::app: [src/app.rs:263] event: Input(Key(KeyEvent { code: Up, modifiers: NONE }))
10:37:03 [TRACE] (1) asyncgit::tags: [asyncgit/src/tags.rs:67] request
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::utils::get_head_repo] @asyncgit/src/sync/utils.rs:106
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::utils::get_head_repo] @asyncgit/src/sync/utils.rs:106
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 0 ms [asyncgit::sync::state::repo_state] @asyncgit/src/sync/state.rs:28
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 5 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (2) scopetime: [scopetime/src/lib.rs:41] scopetime: 6 ms [asyncgit::sync::tags::get_tags] @asyncgit/src/sync/tags.rs:29
10:37:03 [TRACE] (1) scopetime: [scopetime/src/lib.rs:41] scopetime: 2 ms [gitui::loop] @src/main.rs:159
10:37:03 [TRACE] (1) gitui::app: [src/app.rs:263] event: Input(Key(KeyEvent { code: Up, modifiers: NONE }))

it should be only happening maximum every 3s

@extrawurst extrawurst added the bug Something isn't working label Aug 17, 2021
@extrawurst extrawurst changed the title excessive tags fetching in revolt excessive tags fetching in revlog Aug 17, 2021
@extrawurst extrawurst added this to the v0.17 milestone Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant