Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display mark for remote branches with tracking branches #861

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

jedel1043
Copy link
Contributor

Fixes #847.

First contribution here! I'm still getting used to the codebase so please tell me if I overlooked a simpler solution.
Anyways, I choosed the U+2193 (↓) character to represent a remote branch with a tracking branch; it matches with the U+2190 (↑) symbol that represents a local branch with a remote tracking branch. If you find a more fitting symbol for this, I'll gladly change it.

@jedel1043 jedel1043 changed the title Display mark for remote branches with tracking branches Display mark for remote branches with tracking branches (#847) Aug 20, 2021
@jedel1043 jedel1043 changed the title Display mark for remote branches with tracking branches (#847) Display mark for remote branches with tracking branches Aug 20, 2021
@extrawurst
Copy link
Owner

Hi @jedel1043 thanks for tackling this. looks pretty good already. can you please add a test for get_branches_info that specifically tests for the new has_tracking correctly set?

@jedel1043
Copy link
Contributor Author

Hi @jedel1043 thanks for tackling this. looks pretty good already. can you please add a test for get_branches_info that specifically tests for the new has_tracking correctly set?

I'm on it.

@jedel1043
Copy link
Contributor Author

Added test and the auxiliar function remote_details to complement the function local_details. Let me know if there's something else missing.

Copy link
Owner

@extrawurst extrawurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just one last comment

@extrawurst extrawurst merged commit 13a0f4e into extrawurst:master Aug 20, 2021
@extrawurst
Copy link
Owner

@jedel1043 thanks for your contribution ❤️

@jedel1043
Copy link
Contributor Author

@jedel1043 thanks for your contribution ❤️

Thank you for the quick reviews! 😁
I hope I can contribute a lot more to this project!

@jedel1043 jedel1043 deleted the tracking-mark branch August 20, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mark remote branches having tracking branches
2 participants