-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display mark for remote branches with tracking branches #861
Conversation
e05e6a9
to
3a0aedc
Compare
Hi @jedel1043 thanks for tackling this. looks pretty good already. can you please add a test for |
I'm on it. |
Added test and the auxiliar function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 just one last comment
a989054
to
0e69fac
Compare
@jedel1043 thanks for your contribution ❤️ |
Thank you for the quick reviews! 😁 |
Fixes #847.
First contribution here! I'm still getting used to the codebase so please tell me if I overlooked a simpler solution.
Anyways, I choosed the U+2193 (↓) character to represent a remote branch with a tracking branch; it matches with the U+2190 (↑) symbol that represents a local branch with a remote tracking branch. If you find a more fitting symbol for this, I'll gladly change it.