Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We get (?) a warning when setting attributes of the HTML element #22

Open
eyalroz opened this issue Aug 11, 2020 · 0 comments
Open

We get (?) a warning when setting attributes of the HTML element #22

eyalroz opened this issue Aug 11, 2020 · 0 comments
Labels
question Further information is requested task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Aug 11, 2020

We get this warning:

When rendering the element, the used values of CSS properties “writing-mode”, “direction”, and “text-orientation” on the element are taken from the computed values of the element, not from the element’s own values. Consider setting these properties on the :root CSS pseudo-class. For more information see “The Principal Writing Mode” in https://www.w3.org/TR/css-writing-modes-3/#principal-flow INBOX>180552

Perhaps it's because we set the HTML element's class to "bidiui-use-detected-directions"? We could, instead, set the body and the head's class to that, instead.
@eyalroz eyalroz added question Further information is requested task labels Aug 11, 2020
eyalroz pushed a commit that referenced this issue Aug 12, 2020
Fixes #25, regards issue #22:
2014828 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
@eyalroz eyalroz mentioned this issue Aug 12, 2020
Closed
eyalroz pushed a commit that referenced this issue Aug 12, 2020
Fixes #25, regards issue #22:
b4251fb 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
eyalroz pushed a commit that referenced this issue Aug 13, 2020
Fixes #25, regards issue #22:
b29ec99 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
eyalroz pushed a commit that referenced this issue Aug 14, 2020
Fixes #25, regards issue #22:
baa45bb 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
eyalroz pushed a commit that referenced this issue Aug 16, 2020
Fixes #25, regards issue #22:
fee4683 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
eyalroz pushed a commit that referenced this issue Sep 5, 2020
Fixes #25, regards issue #22:
a3cdaa7 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
eyalroz pushed a commit that referenced this issue Sep 5, 2020
Fixes #25, regards issue #22:
f582f39 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
eyalroz pushed a commit that referenced this issue Sep 5, 2020
Fixes #25, regards issue #22:
e339c74 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
eyalroz pushed a commit that referenced this issue Sep 5, 2020
Fixes #25, regards issue #22:
703eec3 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz