Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Am injecting stylesheets as children of the html, not the head #25

Closed
eyalroz opened this issue Aug 12, 2020 · 0 comments
Closed

Am injecting stylesheets as children of the html, not the head #25

eyalroz opened this issue Aug 12, 2020 · 0 comments
Assignees
@eyalroz
Labels
task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Aug 12, 2020

We should inject/append stylesheets to a message as children of the head element, not of the html element like we do now.
@eyalroz eyalroz added the task label Aug 12, 2020
@eyalroz eyalroz self-assigned this Aug 12, 2020
eyalroz pushed a commit that referenced this issue Aug 12, 2020
Fixes #25, regards issue #22:
2014828 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
@eyalroz eyalroz mentioned this issue Aug 12, 2020
Closed
eyalroz pushed a commit that referenced this issue Aug 12, 2020
Fixes #25, regards issue #22:
b4251fb 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
eyalroz pushed a commit that referenced this issue Aug 13, 2020
Fixes #25, regards issue #22:
b29ec99 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
eyalroz pushed a commit that referenced this issue Aug 14, 2020
Fixes #25, regards issue #22:
baa45bb 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
eyalroz pushed a commit that referenced this issue Aug 16, 2020
Fixes #25, regards issue #22:
fee4683 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
eyalroz pushed a commit that referenced this issue Sep 5, 2020
Fixes #25, regards issue #22:
a3cdaa7 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
eyalroz pushed a commit that referenced this issue Sep 5, 2020
Fixes #25, regards issue #22:
f582f39 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
eyalroz pushed a commit that referenced this issue Sep 5, 2020
Fixes #25, regards issue #22:
e339c74 
* Now making sure to add stylesheet link elements to the `<head>` element, not the root `<html>` element, of a message.
* Now using an attribute on the HTML element instead of a class

but the warning persists...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz