New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message document rendering ignores our injected stylesheet #20

Closed

eyalroz opened this issue Aug 10, 2020 · 1 comment

Assignees

Labels

bug

Milestone

Thunderbird 78 co...

Owner

eyalroz commented Aug 10, 2020

With the TB-78-compatible - injected - versions, direction autodetection fails quietly; not sure why.

eyalroz added the bug label

eyalroz self-assigned this

eyalroz added this to the Thunderbird 78 compatibility milestone

eyalroz changed the title ~~Direction autodetection fails~~ Message document rendering ignores our injected stylesheet

Owner Author

eyalroz commented Aug 12, 2020

Status so far:

It's some issue with the stylesheet.
It's not issue We get (?) a warning when setting attributes of the HTML element #22, nor issue Unload self-loaded stylesheets when extension is unloaded? #24 , nor Am injecting stylesheets as children of the html, not the head #25.
html:link has no effect when injected - as though it's ignored.
If we try to inject a link element created with createElement(), we get a security error about content trying to access chrome. How do we bypass that? John Bieling may be able to find a way.
A workaround could be injecting CSS text rather than a link.

eyalroz pushed a commit that referenced this issue


          Regards #20:

2255d15

* Workaround for ignored stylesheets - now injecting style elements as text
* Changed the previously-implemented link injectors to create non-HTML elements (`createElement()` with no namespace) - so that it triggers the security error - but at least there's an _attempt_ to load the sheet.

eyalroz pushed a commit that referenced this issue


          Regards #20:

85a0f2c

* Workaround for ignored stylesheets - now injecting style elements as text
* Changed the previously-implemented link injectors to create non-HTML elements (`createElement()` with no namespace) - so that it triggers the security error - but at least there's an _attempt_ to load the sheet.

eyalroz pushed a commit that referenced this issue


          Regards #20:

9326e3d

* Workaround for ignored stylesheets - now injecting style elements as text
* Changed the previously-implemented link injectors to create non-HTML elements (`createElement()` with no namespace) - so that it triggers the security error - but at least there's an _attempt_ to load the sheet.

eyalroz pushed a commit that referenced this issue


          Fixes #20: TB will no longer ignore our injected stylesheets for docu…

5979c1b

…ment (and no need for the workaround)

* Removed the style-element-with-no-link workaround code.
* Other changes to the stylesheet-link-adding function; specifically, still using a non-namespaced link element.
* Apparently, Thunderbird _is_ willing to use linked chrome in content documents if it's via a `resource://` URI; so - doing that:
   * Registering our chrome folder for use as a "resource"
   * Tweaked the stylesheet injector function to use a `resource://` URI

eyalroz pushed a commit that referenced this issue


          Regards #20:

d53217a

* Workaround for ignored stylesheets - now injecting style elements as text
* Changed the previously-implemented link injectors to create non-HTML elements (`createElement()` with no namespace) - so that it triggers the security error - but at least there's an _attempt_ to load the sheet.

eyalroz pushed a commit that referenced this issue


          Fixes #20: TB will no longer ignore our injected stylesheets for docu…

f363270

…ment (and no need for the workaround)

* Removed the style-element-with-no-link workaround code.
* Other changes to the stylesheet-link-adding function; specifically, still using a non-namespaced link element.
* Apparently, Thunderbird _is_ willing to use linked chrome in content documents if it's via a `resource://` URI; so - doing that:
   * Registering our chrome folder for use as a "resource"
   * Tweaked the stylesheet injector function to use a `resource://` URI

eyalroz pushed a commit that referenced this issue


          Regards #20:

16b997c

* Workaround for ignored stylesheets - now injecting style elements as text
* Changed the previously-implemented link injectors to create non-HTML elements (`createElement()` with no namespace) - so that it triggers the security error - but at least there's an _attempt_ to load the sheet.

eyalroz pushed a commit that referenced this issue


          Fixes #20: TB will no longer ignore our injected stylesheets for docu…

38563c7

…ment (and no need for the workaround)

* Removed the style-element-with-no-link workaround code.
* Other changes to the stylesheet-link-adding function; specifically, still using a non-namespaced link element.
* Apparently, Thunderbird _is_ willing to use linked chrome in content documents if it's via a `resource://` URI; so - doing that:
   * Registering our chrome folder for use as a "resource"
   * Tweaked the stylesheet injector function to use a `resource://` URI

eyalroz pushed a commit that referenced this issue


          Regards #20:

dc63475

* Workaround for ignored stylesheets - now injecting style elements as text
* Changed the previously-implemented link injectors to create non-HTML elements (`createElement()` with no namespace) - so that it triggers the security error - but at least there's an _attempt_ to load the sheet.

eyalroz pushed a commit that referenced this issue


          Fixes #20: TB will no longer ignore our injected stylesheets for docu…

1c59ad9

…ment (and no need for the workaround)

* Removed the style-element-with-no-link workaround code.
* Other changes to the stylesheet-link-adding function; specifically, still using a non-namespaced link element.
* Apparently, Thunderbird _is_ willing to use linked chrome in content documents if it's via a `resource://` URI; so - doing that:
   * Registering our chrome folder for use as a "resource"
   * Tweaked the stylesheet injector function to use a `resource://` URI

eyalroz pushed a commit that referenced this issue


          Regards #20:

ba5649b

* Workaround for ignored stylesheets - now injecting style elements as text
* Changed the previously-implemented link injectors to create non-HTML elements (`createElement()` with no namespace) - so that it triggers the security error - but at least there's an _attempt_ to load the sheet.

eyalroz pushed a commit that referenced this issue


          Fixes #20: TB will no longer ignore our injected stylesheets for docu…

a5c2b9c

…ment (and no need for the workaround)

* Removed the style-element-with-no-link workaround code.
* Other changes to the stylesheet-link-adding function; specifically, still using a non-namespaced link element.
* Apparently, Thunderbird _is_ willing to use linked chrome in content documents if it's via a `resource://` URI; so - doing that:
   * Registering our chrome folder for use as a "resource"
   * Tweaked the stylesheet injector function to use a `resource://` URI

eyalroz pushed a commit that referenced this issue


          Regards #20:

d64075a

* Workaround for ignored stylesheets - now injecting style elements as text
* Changed the previously-implemented link injectors to create non-HTML elements (`createElement()` with no namespace) - so that it triggers the security error - but at least there's an _attempt_ to load the sheet.

eyalroz pushed a commit that referenced this issue


          Fixes #20: TB will no longer ignore our injected stylesheets for docu…

…ment (and no need for the workaround)

* Removed the style-element-with-no-link workaround code.
* Other changes to the stylesheet-link-adding function; specifically, still using a non-namespaced link element.
* Apparently, Thunderbird _is_ willing to use linked chrome in content documents if it's via a `resource://` URI; so - doing that:
   * Registering our chrome folder for use as a "resource"
   * Tweaked the stylesheet injector function to use a `resource://` URI

eyalroz pushed a commit that referenced this issue


          Regards #20:

d742eb4

* Workaround for ignored stylesheets - now injecting style elements as text
* Changed the previously-implemented link injectors to create non-HTML elements (`createElement()` with no namespace) - so that it triggers the security error - but at least there's an _attempt_ to load the sheet.

eyalroz closed this as completed in

9d9d5de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment