Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser- File - New Container Tab #126

Closed
Shoalsteed opened this issue Sep 28, 2022 · 9 comments
Closed

Browser- File - New Container Tab #126

Shoalsteed opened this issue Sep 28, 2022 · 9 comments

Comments

@Shoalsteed
Copy link

Trying to access the console or mail from this tab takes me to the Extension home page.
However , if I choose the I2P Browser, it does open a functional tab and I can get to an I2P site.
Screen Shot 2022-09-28 at 2 32 10 PM
Screen Shot 2022-09-28 at 2 34 45 PM
Screen Shot 2022-09-28 at 10 39 10 AM

@eyedeekay
Copy link
Owner

I cant change this, container tabs can't set individual homepages. The closest I can get is to override them with the extension homepage. I might be able to figure out some kind of workaround but this one might need to be a wontfix

@Shoalsteed
Copy link
Author

Just so I understand: none of these ( ( Dispatch, MuWire, Etc) have any linking functionality?

@eyedeekay
Copy link
Owner

They can be forced into the internal extension page but the user needs to click the respective link on the extension page to reach the application. I might be able to work around it by redirecting but I don't know if I can reliably tell that it's the first time they've opened the tab. Could end up with situations that spam a bunch of tabs because it keeps trying to re-isolate.

@Shoalsteed
Copy link
Author

Since these redirect to the home page , then maybe just have a note in the applications section with email, hidden services, and snark that any applications that are available in your console will open in a container ?

@eyedeekay
Copy link
Owner

eyedeekay commented Sep 30, 2022

Ok sure. However, the rule for containerizing in this plugin is that if it's not happening automatically, then it's broken and the real problem is that. They shouldn't, and as far as I know, aren't, able to approach any console page, application, or I2P site from a path where the automatic isolation isn't triggered, in fact the entire UI is just different ways of triggering the automatic isolation function. This workaround is only necessary when triggering it from Mozilla's container-tab UI, and not from the browserAction menu or any of the myriad ways of automatically triggering the isolator, and it doesn't actually require them to read the warning to work correctly, and not because the normal isolator isn't working, just because there can only be one homepage.

@Shoalsteed
Copy link
Author

Ok sure. However, the rule for containerizing in this plugin is that if it's not happening automatically, then it's broken and the real problem is that. They shouldn't, and as far as I know, aren't, able to approach any console page, application, or I2P site from a path where the automatic isolation isn't triggered, in fact the entire UI is just different ways of triggering the automatic isolation function. This workaround is only necessary when triggering it from Mozilla's container-tab UI, and not from the browserAction menu or any of the myriad ways of automatically triggering the isolator, and it doesn't actually require them to read the warning to work correctly, and not because the normal isolator isn't working, just because there can only be one homepage.

Yes, this sounds like the workaround.

@eyedeekay
Copy link
Owner

Current screenshot of the page they get redirected to if they open a tab from the File menu

current

@Shoalsteed
Copy link
Author

Should this issue be closed?

@eyedeekay
Copy link
Owner

Yes I think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants