Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should we remove the eye.pl APIs entirely #25

Closed
jeswr opened this issue Jan 8, 2023 · 1 comment
Closed

should we remove the eye.pl APIs entirely #25

jeswr opened this issue Jan 8, 2023 · 1 comment

Comments

@jeswr
Copy link
Collaborator

jeswr commented Jan 8, 2023

In #21 I have marked all APIs that instantiate eye via eye.pl as deprecated; favoring initialization with eye.pvm. I have also updated the docs accordingly.

I would like to know if there is any value in keeping these APIs or whether we can just remove them entirely; and make this library easier to maintain.

// cc @josd
@josd
Copy link
Contributor

josd commented Jan 8, 2023

Not sure but I would be inclined to remove those APIs.

@jeswr jeswr closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josd @jeswr