Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enable possibility of using KSPACING #8

Closed
ezpzbz opened this issue Aug 7, 2020 · 2 comments
Closed

[Feature] Enable possibility of using KSPACING #8

ezpzbz opened this issue Aug 7, 2020 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@ezpzbz
Copy link
Owner

ezpzbz commented Aug 7, 2020

My initial inspection and tests reveals that it is not currently possible at plugin level. Although there is function _need_kp which would check whether kpoints are required to parse, in the base part of calculation plugin there is not exception and it goes for parsing and writing KPOINTS.
I need to investigate it in more detail to see if there would be workarounds to avoid modifying the plugin (which seems to me inevitable).
However, it is already seen in our workchain and fixing this issue should not be a big deal.

@ezpzbz ezpzbz added bug Something isn't working enhancement New feature or request labels Aug 7, 2020
@ezpzbz ezpzbz added this to the v0.3.0 milestone Aug 7, 2020
@ezpzbz ezpzbz self-assigned this Aug 7, 2020
@ezpzbz
Copy link
Owner Author

ezpzbz commented Aug 14, 2020

It is fixed now.
I opened a PR in aiida-vasp with the fix:
aiida-vasp/aiida-vasp#377

Currently, we can use my kspcing branch to have this option available!
https://github.com/pzarabadip/aiida-vasp/tree/kspacing

@ezpzbz ezpzbz closed this as completed Aug 14, 2020
@ezpzbz
Copy link
Owner Author

ezpzbz commented Aug 14, 2020

It can be solved in another ways using AiiDA KpointsData object that can be constructed as:

from aiida.plugins import DataFactory
KpointsData = DataFactory('array.kpoints')
KpointsData.set_kpoints_mesh_from_density(distance, offset, force_parity)

Here is the link to the function. I'm leaving it here for later inclusion in our documentation when addressing #14
https://github.com/aiidateam/aiida-core/blob/f2d1e9492ee33304fd197b0c8788896f76abb17d/aiida/orm/nodes/data/array/kpoints.py#L296-L313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant