Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-4031: Forced published non-translatable field to be shown in current field #71

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Aug 1, 2023

Question Answer
JIRA issue IBX-4031
Type bug
Target Ibexa version v3.3
BC breaks no

Following PR assures that in content edit form there is a 'fresh' value set for fields that are non-translatable. Those values are taken from main published version.

Related PR: ezsystems/ezplatform-kernel#380

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@barw4
Copy link
Member Author

barw4 commented Aug 1, 2023

@mnocon seems like Behat is failing, changes are unrelated. Most likely we will have a similar issue on the main branch.

@mnocon
Copy link
Member

mnocon commented Aug 1, 2023

@barw4 could you backport this change ibexa/content-forms#44 into your PR? This should solve it

@barw4
Copy link
Member Author

barw4 commented Aug 1, 2023

@mnocon looks all good now, thank you

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bogusez bogusez self-assigned this Aug 10, 2023
@bogusez
Copy link

bogusez commented Aug 10, 2023

Regression tests passed:
ibexa/oss#109

@konradoboza konradoboza merged commit 51c3d92 into 1.3 Aug 10, 2023
13 checks passed
@konradoboza konradoboza deleted the ibx-4031-force-published-non-translatable-field-form branch August 10, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7 participants