EZP-23441: IO url decorators configuration #1028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunogier
changed the title
bdunogier
force-pushed
the
EZP-23441-io_url_decoration
branch
from
2404600
to
6a84199
Compare
|
Shouldn't spec be part of PR? Also seems phpspec is added but does not seem to be used. |
|
|
||
| private function isDynamicSetting( $string ) | ||
| { | ||
| return ( preg_match( "^\$[a-z0-9_\.]+(?:;[a-z0-9_\.]+){0,2}\$$", $string ) ); |
There was a problem hiding this comment.
Why not using DynamicSettingParser ?
There was a problem hiding this comment.
This must be removed. I use ComplexSettingParser, that extends DynamicSettingParser.
|
+1, apart interfaces claims |
EZP-23328: Split IO handlers
bdunogier
force-pushed
the
EZP-23441-io_url_decoration
branch
from
e28ba76
to
151b7e1
Compare
added 12 commits
October 13, 2014 16:27
Added a regexp if the first, lightweight test passes.
Identifies arguments/methods with a complex setting, a string with more than one dynamic setting, or one dynamic setting and anything else. Converts them into factories that dynamically replace the settings in the string with their value.
added 9 commits
October 13, 2014 16:27
Complex parameter in the io.url_prefix ezpublish setting will be parsed and resolved to the real settings in each context it is set for.
Any complex setting must be added to scopes where one of its dependencies (dynamic variables it uses) is declared in this scope, so that it can get its own value written.
Will convert from public url, that use the default url decorator, to what legacy expects to store (note: it leaves the /, while legacy doesn't want it).
bdunogier
force-pushed
the
EZP-23441-io_url_decoration
branch
from
151b7e1
to
da4474c
Compare
added 3 commits
October 13, 2014 19:11
XML parsing from imageStorage has been moved to the LegacyStorage image gateway, and the legacy url redecorator injected to this service. No manual stripping/adding / to uris manually.
bdunogier
force-pushed
the
EZP-23441-io_url_decoration
branch
from
2837410
to
ec7c583
Compare
| @@ -0,0 +1,46 @@ | |||
| # IO URL decoration | |||
|
|
|||
| > Added in 5.4 | |||
added 7 commits
October 17, 2014 12:07
Also checks that delimiters count makes sense.
|
All current comments fixed, closing, and re-opening against master. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to set the prefix for IO uris at siteaccess level. Other siteacces level variables can be used in the configuration.
Absolute prefixes to other hosts are also possible, and will work with legacy data (as long as the file is available from this uri).
Changes
Settings
Most of the changes are about the ConfigResolver:
$var_dir$/$storage_dir$).Complex settings has been added as part of the CoreBundle. Dynamic settings in semantic config is only part of the IOBundle for now, as it is a bit rough around the edges (but should be possible to move it up to the CoreBundle with a bit of work).
url_decorator services
There are now two main url decorators: the default one, and a legacy one. The legacy one is used in the Legacy Converter, via an UrlRedecorator, to convert the system's uris to the format it requires.
Configuration example
TODO