Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement: EZP-24486: Disable FullText search for LocationSearch #1307

Merged
merged 2 commits into from
Jun 18, 2015

Conversation

pspanja
Copy link
Contributor

@pspanja pspanja commented Jun 15, 2015

This PR resolves sub-task https://jira.ez.no/browse/EZP-24486

Schema is changed to index to fulltext text field over proxy field *_fulltext_t, which is not indexed nor stored, but is copied to it.
Location index now does not index to text field by omitting *_fulltext_t fields and not registering FullText criterion.

@pspanja
Copy link
Contributor Author

pspanja commented Jun 15, 2015

Ready for review, ping @paulborgermans @andrerom @lolautruche @bdunogier

@andrerom
Copy link
Contributor

BC docs

@pspanja
Copy link
Contributor Author

pspanja commented Jun 16, 2015

@andrerom do we need BC notes for Solr engine? Legacy doesn't support it either.

@andrerom
Copy link
Contributor

ah, so LegacySearch engine does also not support FullText? if so ignore and +1

side side note: possible future discussion could be about deprecating ->query on LocationQuery to make it clear only filtering is supported on it, this might also be relevant to named / persisted queries in terms of how we explain what filter is vs search. But then it's name, LocationQuery, becomes a bit strange / cc @bdunogier

protected function mapContentFields(
Content $content,
ContentType $contentType,
$indexFulltext
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe cast $indexFulltext to bool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean cast or default value?

@lolautruche
Copy link
Contributor

+1 besides comment

@andrerom
Copy link
Contributor

+1

@andrerom
Copy link
Contributor

Merging to be able to close issue, please add cast and default value of false in followup ;)

andrerom added a commit that referenced this pull request Jun 18, 2015
…on-fulltext-solr

Implement: EZP-24486: Disable FullText search for LocationSearch
@andrerom andrerom merged commit 8059f39 into master Jun 18, 2015
@andrerom andrerom deleted the impl-EZP-24486-disable-location-fulltext-solr branch June 18, 2015 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants