-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement: EZP-24486: Disable FullText search for LocationSearch #1307
Implement: EZP-24486: Disable FullText search for LocationSearch #1307
Conversation
Ready for review, ping @paulborgermans @andrerom @lolautruche @bdunogier |
BC docs |
@andrerom do we need BC notes for Solr engine? Legacy doesn't support it either. |
ah, so LegacySearch engine does also not support FullText? if so ignore and +1 side side note: possible future discussion could be about deprecating ->query on LocationQuery to make it clear only filtering is supported on it, this might also be relevant to named / persisted queries in terms of how we explain what filter is vs search. But then it's name, LocationQuery, becomes a bit strange / cc @bdunogier |
protected function mapContentFields( | ||
Content $content, | ||
ContentType $contentType, | ||
$indexFulltext |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe cast $indexFulltext
to bool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean cast or default value?
+1 besides comment |
+1 |
Merging to be able to close issue, please add cast and default value of |
…on-fulltext-solr Implement: EZP-24486: Disable FullText search for LocationSearch
This PR resolves sub-task https://jira.ez.no/browse/EZP-24486
Schema is changed to index to fulltext
text
field over proxy field*_fulltext_t
, which is not indexed nor stored, but is copied to it.Location index now does not index to
text
field by omitting*_fulltext_t
fields and not registeringFullText
criterion.