[7.x] EZP-27128: New draft based on a selected version doesn't respect ezkeywords value #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
ezp-27128-ezkeyword-versioning
branch
from
fcaf900
to
eff7c33
Compare
alongosz
changed the title
alongosz
force-pushed
the
ezp-27128-ezkeyword-versioning
branch
from
eff7c33
to
faa5de5
Compare
|
After talks with @bdunogier yesterday, db schema changes should ideally be done after we have extracted storage engine and forked it into improved storage engine, leaving legacy storage engine compatible with ... legacy, and if the community wants they can maintain it. As this is field type, do we have a clear plan on being able to have two storage gateways? One for improved storage engine that uses doctrine connection and has possible improved schema, and the existing one. /cc @kore @tobyS |
andrerom
force-pushed
the
7.0
branch
3 times, most recently
from
7542bcc
to
e462d04
Compare
alongosz
force-pushed
the
ezp-27128-ezkeyword-versioning
branch
from
faa5de5
to
011f722
Compare
To begin with this will start as a `7.0` branch, acting as a sort of `develop` branch. So: keep on targeting changes towards master or stable branches as normal, only breaking changes goes just into `7.0` branch For features that are also relevant to 6.x typically in a bc safe way into master, then adaptions to clean up 7.x into `7.0` branhc as seperate pr afterwards _(can be tmp commit on original PR during review)_.
With RHEL now having access to PHP 7.x packages via RHSCL 2.3, and Debian 9 "Stretch" soon out with it also, meaning all support distroes by the time this is stable has PHP 7.0 support. For new code we can thus start to take advantage of PHP 7.0 features, and consider it for existing code and API's where applicable.
…aring with tags (ezsystems#1920) - Removes dependency on Stash - Improves performance by: 1. Use Symfony Cache 2. Use tagging to be able to cache more, and: 3. allow cache item duplication to avoid extra identifier to id lookups before item lookup - Reduces code complexity of cache, for instance no cache warming anymore as it was often warming the wrong object - More reliable, thanks to cache tagging only relevant cache items are cleared on operations, not the whole cache
Reason for using simple regex: - Service is not de-coupled yet to inject Symfony validator cleanly - Besides: https://davidcel.is/posts/stop-validating-email-addresses-with-regex/
RMF is not in use by the server, so since client anyway needs large refactoring somewhat ignoring that this might furhter break it a bit.
…tory.lazy service
alongosz
force-pushed
the
ezp-27128-ezkeyword-versioning
branch
from
011f722
to
82456f2
Compare
|
Todo:
Then rebase this to add this change to Improved Storage engine schema for keyword gateway. |
andrerom
force-pushed
the
7.0
branch
4 times, most recently
from
147d988
to
c1fca2c
Compare
andrerom
force-pushed
the
7.0
branch
2 times, most recently
from
8966281
to
2370875
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors Keyword Storage to associate keyword with content object version.
Due to DB break for Legacy this is targeted for
ezpublish-kernel v7.0.TODO:
ezkeyword_attribute_link.versioncolumn.