Fix EZP-20289 Symfony CSRF protection not integrated with legacy #211
Conversation
This is the Symfony side of things injecting csrf settings if csrf is enabled into api added in ezsystems/ezpublish-legacy#552
| @@ -90,6 +97,14 @@ public function onBuildKernel( PreBuildKernelEvent $event ) | |||
| $settings + (array)$event->getParameters()->get( "injected-settings" ) | |||
| ); | |||
|
|
|||
| // Inject csrf protection settings to make sure legacy & symfony stack work together | |||
| if ( $this->container->hasParameter( 'form.type_extension.csrf.enabled' ) && | |||
There was a problem hiding this comment.
CS : Shouldn't the first condition be on the following line ?
There was a problem hiding this comment.
Maybe, the phpcs profile didn't complain so I just coded it like I'm used to from 4.x cs.
There was a problem hiding this comment.
What do you think, @patrickallaert ?
There was a problem hiding this comment.
Yes @lolautruche, normally ending parenthesis and brackets should be aligned on the same column that the first character of the opening line. I guess the corresponding sniff is working on functions/methods and not yet on language keywords.
There was a problem hiding this comment.
I couldn't find any example on https://github.com/ezsystems/ezp-next/wiki/codingstandards
But I guess it is supposed to be like this?
if (
// expression
)
{
// code
}
This is a part of the new cs I kind of don't like because you get the ending of the parentheses on a new line :)
There was a problem hiding this comment.
@andrerom It has the merit of being very consistent. Whatever the closing is ("}])"), it must always be at the same column level than the first character of the line where it has been opened in the case it's not on the same line.
This is also very easy to program in a code sniffer rule, even if this is not the goal, and hence why that sniff already existed and is used by several standards.
|
+1 |
|
Besides @lolautruche's remark: +1 |
Fix EZP-20289 Symfony CSRF protection not integrated with legacy
This is the Symfony side of things injecting csrf settings if csrf is enabled
into api added in ezsystems/ezpublish-legacy#552