EZP-28148: Object States Limitations perform a lot of lookups #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
approved these changes
Oct 27, 2017
alongosz
requested changes
Oct 27, 2017
adamwojs
approved these changes
Oct 27, 2017
andrerom
force-pushed
the
state_lookup_optimizations
branch
from
e6c717d
to
d17857c
Compare
|
@alongosz better? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause: On installs with a lot of object states the system creates a lot of lookups for them, most notably during permission checks in Object States Limitation Type.
This takes one of the changes in SPI Cache from 7.0, changing from storing id's in cache to the full objects to avoid lookups in loops. 7.0 will be even faster thanks to Symfony Cache, however for now these two changes should hopefully help quite a bit.