Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-28774: Marked PAPI services as public #2360

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

adamwojs
Copy link
Member

Question Answer
JIRA issue EZP-28774
Bug/Improvement yes
New feature no
Target version master
BC breaks no
Tests pass yes
Doc needed no

Since the Symfony 3.4, services which do not specify explicit their visibility are private by default (Ref. https://symfony.com/blog/new-in-symfony-3-4-services-are-private-by-default). Trying to access them directly from container (for instance using has or get method) will generate deprecation warning e.g. "User Deprecated: Checking for the initialization of the "ezpublish.api.repository" private service is deprecated since Symfony 3.4 and won't be supported anymore in Symfony 4.0." (Ref. https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/DependencyInjection/Container.php#L224)

This PR is a very first step to clean up logs from the deprecation warnings

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs requested a review from kmadejski June 22, 2018 07:19
@andrerom andrerom merged commit 65f512f into ezsystems:master Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants